streamripper 1.61 is up

Hi Greg,

I'm showing a nasty memory leak, and I THINK it's in strip_invalid_chars(char *str)

This bit of code:

   for(int j = 0; j < 500; j++)
    {
        char *p = new char[255];
        p[0] = NULL;
        strcpy(p, "This is a test");          ;       
        strip_invalid_chars(p);
       
        delete []p;
            
    }

Leaks "This is a test" 500 times.  If I remove the strip, it doesn't.  Are you seeing this? I actually have copied your function to a local function in the SR stuff (as including it is a pain, but it should be the same).

Adding:

    free(w_in);
    free(w_invalid );

Seems to fix it.

This doesn't actually show up as problem very quick, but if you rip 20 streams at once it gets nasty quick.

Thanks,

-Greg

Hehe, just glad I found it.  I've been stress testing V2.0 for the last week, and was wonder what was up :P

-Greg

Well, this is interesting.

The way the URL to rip changed in this version (in StationRipper).  It APPEARS that some of the URL's on some of these stations are invalid.  If I run the old console against the URL the new one is getting, it also gets the error.

Example:

The 80's channel

[playlist]
numberofentries=4
File1=http://64.236.34.196:80/stream/1040
Title1=(#1 - 1/9584) CLUB 977 The 80s Channel (HIGH BANDWIDTH)
Length1=-1
File2=http://64.236.34.4:80/stream/1040
Title2=(#2 - 2075/18249) CLUB 977 The 80s Channel (HIGH BANDWIDTH)
Length2=-1
File3=http://64.236.34.67:80/stream/1040
Title3=(#3 - 3243/14770) CLUB 977 The 80s Channel (HIGH BANDWIDTH)
Length3=-1
File4=http://205.188.234.66:8010
Title4=(#4 - 10/10) CLUB 977 The 80s Channel (HIGH BANDWIDTH)
Length4=-1
Version=2

The first bold one I get a "not Found".  The second I get a  no header error.  The others work.

I can roll with this - When the user tries to rip, I'll just start at the first and go through until one works. Not fun, not sure what's up...

If I run in WinAmp, I get the same results.  But it works from the main PLS file.  Sooo.. does it just also go through them, or does it always pick #2 or something?

I'll let you know what I find, but ATM it looks like the console is doing what it should :)

-Greg

Yeah.  Annoying.  Wonder what's up? A lot of stations are doing this.

Oh well.  No biggy, the version I'm putting out tonight will deal with this.  Nice actually, in that it will just start at the first and go until the end or it finds one it can rip.  User doesn't see anything unless it fails.

-Greg